Open
Conversation
relates to STACKITCLI-307 and #1214
Fixed tests and linter relates to STACKITCLI-307 and #1214
relates to STACKITCLI-307 and #1214 tests added network ids included in list of project NICs
rubenhoenle
reviewed
Jan 26, 2026
rubenhoenle
reviewed
Jan 26, 2026
| } | ||
|
|
||
| // Truncate output | ||
| items := *resp.Items |
Member
There was a problem hiding this comment.
Potential nil pointer dereference, take care of it please
Member
There was a problem hiding this comment.
rubenhoenle
reviewed
Jan 26, 2026
rubenhoenle
reviewed
Jan 26, 2026
rubenhoenle
reviewed
Jan 26, 2026
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
rubenhoenle
reviewed
Jan 30, 2026
| if err != nil { | ||
| projectLabel = model.ProjectId | ||
| } | ||
| params.Printer.Outputf("No network interfaces found for project %q\n", projectLabel) |
Member
There was a problem hiding this comment.
Same as in your other PR. This belongs into outputResult, else you will have invalid JSON/YAML output here.
rubenhoenle
reviewed
Jan 30, 2026
rubenhoenle
reviewed
Jan 30, 2026
| networkLabel = *model.NetworkId | ||
| } | ||
| params.Printer.Info("No network interfaces found for network %q\n", networkLabel) | ||
| params.Printer.Outputf("No network interfaces found for network %q\n", networkLabel) |
Member
There was a problem hiding this comment.
invalid JSON/YAML output, see comment above
rubenhoenle
reviewed
Jan 30, 2026
| args: args{}, | ||
| wantErr: false, | ||
| }, | ||
| { |
Member
There was a problem hiding this comment.
can we have some more test-cases for the output result stuff please?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITCLI-307 and #1214
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)